Skip to content

Add registry portion #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add registry portion #82

wants to merge 1 commit into from

Conversation

@jpraychev
Copy link
Contributor

@jpraychev jpraychev commented Sep 24, 2025 •
edited
Loading

What this PR does / why we need it:
The PR introduces a new variable global.imageRegistry which allows users to separately define the registry where the image is hosted. This is handy when it comes down to building localization rules in OCM. By having the repository containing the registry + repository strings, OCM localization rules cannot simply substitute the corresponding values and users will be required to add additional logic just to separate the two.

The change will basically allow users to either define the image path as:

# values.yaml
global:
  imageRegistry: ghcr.io

image:
  repository: openmcp-project/github.com/openmcp-project/metrics-operator/images/metrics-operator
  pullPolicy: IfNotPresent
  # Overrides the image tag whose default is the chart appVersion.
  tag: v0.6.1
#
# Deployment spec result:
image: "ghcr.io/openmcp-project/github.com/openmcp-project/metrics-operator/images/metrics-operator:v0.6.1"

or

# values.yaml
image:
  repository: ghcr.io/openmcp-project/github.com/openmcp-project/metrics-operator/images/metrics-operator
  pullPolicy: IfNotPresent
  # Overrides the image tag whose default is the chart appVersion.
  tag: v0.6.1
#
# Deployment spec result:
image: "ghcr.io/openmcp-project/github.com/openmcp-project/metrics-operator/images/metrics-operator:v0.6.1"

Release note:
Add new registry value

@cla-assistant
Copy link

cla-assistant bot commented Sep 24, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Jordan Raychev seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jpraychev jpraychev closed this Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jpraychev